Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIMS-832]Feature: Use shipping service for incoming shipments #630

Merged
merged 12 commits into from
Aug 14, 2023
Merged

[LIMS-832]Feature: Use shipping service for incoming shipments #630

merged 12 commits into from
Aug 14, 2023

Conversation

MattPrit
Copy link
Contributor

@MattPrit MattPrit commented Jul 14, 2023 •
edited
Loading

Requires #618

JIRA ticket: LIMS-832

Changes:

  • Add config parameter $use_shipping_service_incoming_shipments to toggle using the shipping service for incoming shipments
  • Make requests to the shipping service for booking incoming shipments
  • Fix problem logging $shipment_data on shipping service dispatch error
  • Format address and post code when first loading the dispatch form

To test:

  • Check that, with $use_shipping_service_incoming_shipments=true;, shipments are created/updated in the shipping service when booking an incoming shipment
  • Check that SynchWeb behaviour is unchanged when booking an incoming shipment

@MattPrit MattPrit self-assigned this Jul 14, 2023
@MattPrit MattPrit changed the title Feature/lims 832/shipping service incoming shipments [LIMS-832]Feature: Use shipping service for incoming shipments Jul 14, 2023
John-Holt-Tessella
John-Holt-Tessella approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@John-Holt-Tessella John-Holt-Tessella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have updated a couple of things

api/src/Page/Shipment.php Outdated Show resolved Hide resolved
@John-Holt-Tessella
Copy link
Contributor

@MattPrit if you are happy with the last 3 commits can you merge and move the ticket along please?

@John-Holt-Tessella John-Holt-Tessella merged commit 2da5639 into prerelease Aug 14, 2023
2 checks passed
@John-Holt-Tessella John-Holt-Tessella deleted the feature/lims-832/shipping-service-incoming-shipments branch August 14, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Holt-Tessella John-Holt-Tessella John-Holt-Tessella approved these changes

Assignees

@MattPrit MattPrit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattPrit @John-Holt-Tessella